Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compression level 1 for PB files (81X) #15903

Merged
merged 1 commit into from
Sep 23, 2016
Merged

Compression level 1 for PB files (81X) #15903

merged 1 commit into from
Sep 23, 2016

Conversation

smorovic
Copy link
Contributor

DQM changes seen to improve DAQ/HLT performance in timing benchmarks:

  • compression level 1 for PB files (performance improvement for online)
  • before adding check if histogram has been filled (better performance in case of many histograms not filled in a lumisection)

@smorovic
* compression level 1 for PB files
02b4593 
* before adding check if histogram has been filled
@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Sep 19, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_8_1_X.

It involves the following packages:

DQMServices/Core

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@smorovic smorovic mentioned this pull request Sep 19, 2016
Merged
@dmitrijus
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2016 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15265/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 02b4593
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15903/15265/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15903/15265/summary.html

@dmitrijus
Copy link
Contributor

+1

Sorry for being slow - I was worried that "GetEntries()" won't be properly set.
This is because many DQM modules populate histograms via SetBinContent,
however, checking the root code - "SetBinContent" does increment the "fEntries" counter.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 90902b9 into cms-sw:CMSSW_8_1_X Sep 23, 2016
@smorovic smorovic deleted the compression-add-81X branch May 7, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@smorovic @cmsbuild @dmitrijus @davidlange6